test(sim): connext instability tests #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
reviewed
Jul 17, 2020
| @@ -16,9 +16,4 @@ pushd temp/indra | |||
| make reset | |||
| popd | |||
|
|
|||
| if [[ retVal != 0 ]] | |||
| then | |||
| ./logs.sh | |||
There was a problem hiding this comment.
Removing this will prevent the logs from printing on failure, right?
There was a problem hiding this comment.
Yes, I saw you added a similar thing to simtest.yml workflow, so it was redundant (assuming we don't need it for local runs).
There was a problem hiding this comment.
I think for local runs we can easily check the temp/logs folder for output.
|
Did you try to clean and re-build everything? Also, try to restart Docker engine. |
ghost
approved these changes
Jul 17, 2020
|
@sangaman need to merge, please contact me if you still have local issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test scenarios:
Code structure is still problematic, waiting for #1111 resolution.
Next to be implemented : #1712 (for both
lndandconnext).